[jboss-jira] [JBoss JIRA] Updated: (JBAS-3727) NPE on context classloader changing in EJB container when caller doesn't have a context classloader

[Dimitris Andreadis (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBAS-3727?page=all ]

Dimitris Andreadis updated JBAS-3727:
-------------------------------------

    Affects Version/s: JBossAS-3.2.8.SP1

> NPE on context classloader changing in EJB container when caller doesn't have a context classloader
> ---------------------------------------------------------------------------------------------------
>
>                 Key: JBAS-3727
>                 URL: http://jira.jboss.com/jira/browse/JBAS-3727
>             Project: JBoss Application Server
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: EJB2
>    Affects Versions: JBossAS-4.0.5.CR1, JBossAS-3.2.8.SP1
>            Reporter: Adrian Brock
>         Assigned To: Dimitris Andreadis
>             Fix For: JBossAS-5.0.0.Beta, JBossAS-4.0.5.GA
>
>
> The following code in org.jboss.ejb.Container
> doesn't work if the caller doesn't have a context classloader,
> e.g. it is using the bootstrap classloader as its classloader on the Sun JDK
>       ClassLoader callerClassLoader = SecurityActions.getContextClassLoader();
>       long start = System.currentTimeMillis();
>       Method m = null;
>       boolean setCl = false;
>       Object type = null;
>       String contextID = getJaccContextID();
>       try
>       {
>          if (!callerClassLoader.equals(classLoader)) // !!! callerClassLoader is null !!!
>          {
>             setCl = true;
>             SecurityActions.setContextClassLoader(this.classLoader);
>          }
> The classloaders should be reversed, since the ejb classloader can never be null.
> Is there a reason for this optimization? I'd imagine the comparison of classloaders
> is likely to be more expensive that just setting the TCL in some cases????

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira