[jboss-jira] [JBoss JIRA] Commented: (JBREM-731) Address of secondary server socket should be acquired each time a control connection is created.

[Ron Sigal (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBREM-731?page=comments#action_12358638 ] 
            
Ron Sigal commented on JBREM-731:
---------------------------------

Two changees have been made.

1. The address of the secondary server socket is acquired each time a control connection is created.

2. Suppose a server crashes and is restarted.  When the callback BisocketServerInvoker detects a failure on a control connection, it will be able to recreate it.  However, if the server doesn't keep pinging the connection, it will just keep dying.  When a callback BisocketServerInvoker detects a change in secondary server socket port, it counts the number of times a control connection has been restarted, and when a configured maximum has been reached, it lets the connection die.  Constants MAX_CONTROL_CONNECTION_RESTARTS and MAX_CONTROL_CONNECTION_RESTARTS_DEFAULT have been added to org.jboss.remoting.transport.bisocket.Bisocket to facilitate configuring the maximum, which defaults to 10.

Unit tests:  Methods testServerQuickRestart() and testDeadControlConnectionShutdown() have been added to org.jboss.test.remoting.transport.bisocket.BisocketTestCase.

Waiting for cruisecontrol results.

> Address of secondary server socket should be acquired each time a control connection is created.
> ------------------------------------------------------------------------------------------------
>
>                 Key: JBREM-731
>                 URL: http://jira.jboss.com/jira/browse/JBREM-731
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.2.0.GA (Bluto)
>            Reporter: Ron Sigal
>         Assigned To: Ron Sigal
>             Fix For: 2.4.0.Beta1 (Pinto)
>
>
> Scenario:  Client is connected to a server, server dies, and server is restarted (with same InvokerLocator).  The new server creates a secondary server socket on a different port than the previous server, but the client invoker retains the old secondary server socket InvokerLocator.  When a new Client is created, the old client invoker gets reused, and it isn't possible to create a control connection.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira