[jboss-jira] [JBoss JIRA] Resolved: (JGRP-473) SFC should aggressively send credits

[Bela Ban (JIRA)]

     [ http://jira.jboss.com/jira/browse/JGRP-473?page=all ]

Bela Ban resolved JGRP-473.
---------------------------

    Resolution: Done

Not sure whether we use SFC for the 2.4 branch. Pending the discussion with Brian, I might remove SFC from 2.4. We should probbably use FC (with the changes applied) in 2.4.

> SFC should aggressively send credits
> ------------------------------------
>
>                 Key: JGRP-473
>                 URL: http://jira.jboss.com/jira/browse/JGRP-473
>             Project: JGroups
>          Issue Type: Task
>            Reporter: Brian Stansberry
>         Assigned To: Brian Stansberry
>             Fix For: 2.4.1 SP2
>
>
> SFC sends credits when it has seen max_credits.  This means the sender will always block before receiving credits.  In HEAD, the credit replenishments are sent OOB, so the idea is the blocking period should be short.  However, Branch_2_4 does not have OOB messages, so blocking periods could be significant, particularly if the receiver is also sending a lot of messages.
> Solution to this is to send credits when a configurable number of messages have been seen, with the configurable number being < max_credits.  Any credit replenishment message should include the number of bytes seen; sender only gives himself that many credits.  This maintains SFC's guarantee of not granting more credit than what has been seen.
> This may be appropriate in HEAD as well, as even an OOB message could take a while to travel.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira