[jboss-jira] [JBoss JIRA] Closed: (JGRP-475) Logging IOExceptions in BasicConnectionTable

[Bela Ban (JIRA)]

     [ http://jira.jboss.com/jira/browse/JGRP-475?page=all ]

Bela Ban closed JGRP-475.
-------------------------

    Resolution: Won't Fix

I logged the exception earlier, but chose to remove it because
- It didn't create much information besides the IOexception
- It cluttered up the log files

> Logging IOExceptions in BasicConnectionTable
> --------------------------------------------
>
>                 Key: JGRP-475
>                 URL: http://jira.jboss.com/jira/browse/JGRP-475
>             Project: JGroups
>          Issue Type: Bug
>    Affects Versions: 2.4.1 SP1
>            Reporter: Galder Zamarreno
>         Assigned To: Bela Ban
>            Priority: Minor
>             Fix For: 2.4.1 SP2, 2.5
>
>
> BasicConnectionTable contains this code:
>        private void _send(byte[] data, int offset, int length) {
>            synchronized(send_mutex) {
>                try {
>                    doSend(data, offset, length);
>                    updateLastAccessed();
>                }
>                catch(IOException io_ex) {
>                    if(log.isWarnEnabled())
>                        log.warn("peer closed connection, trying to re-send msg");
>                    try {
>                        doSend(data, offset, length);
>                        updateLastAccessed();
>                    }
>                    catch(IOException io_ex2) {
>                        if(log.isErrorEnabled()) log.error("2nd attempt to send data failed too");
>                    }
>                    catch(Exception ex2) {
>                        if(log.isErrorEnabled()) log.error("exception is " + ex2);
>                    }
>                }
>                catch(InterruptedException iex) {}
>                catch(Throwable ex) {
>                    if(log.isErrorEnabled()) log.error("exception is " + ex);
>                }
>            }
>        }
> io_ex and io_ex2 should be logged, otherwise you get these messages without any reason why it failed:
> 2007-04-15 01:04:43,425 WARN  [org.jgroups.blocks.ConnectionTable] sender thread was interrupted, but is still alive: Thread[ConnectionTable.Connection.Sender [143.61.17.44:55413 - 209.82.241.31:7100],5,ConnectionTableGroup]
> 2007-04-15 01:04:43,425 WARN  [org.jgroups.blocks.ConnectionTable] peer closed connection, trying to re-send msg
> 2007-04-15 01:04:43,426 ERROR [org.jgroups.blocks.ConnectionTable] 2nd attempt to send data failed too

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira