[jboss-jira] [JBoss JIRA] Commented: (JBRULES-808) DefaultExpander not failing when it should (partial expansion)

[Edson Tirelli (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBRULES-808?page=comments#action_12360200 ] 
            
Edson Tirelli commented on JBRULES-808:
---------------------------------------

Michael,

It depends on what we want:

* If we want complete control and handle DSL grammars as a higher level Regexp/Template engine, I would say the above expansion is valid and the DRL will report the error, not the DSL expander. As I mentioned to you before, I prefer such approach, but I see the your point. So alternative 2 is:

* If we want a more restrict DSL template engine, then the above should not be expanded. The fix is a 2 line change in the code (already did just to test, but didn't commited yet).

So, question is, what do we want?



> DefaultExpander not failing when it should (partial expansion)
> --------------------------------------------------------------
>
>                 Key: JBRULES-808
>                 URL: http://jira.jboss.com/jira/browse/JBRULES-808
>             Project: JBoss Rules
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Drl Parser/Builder
>            Reporter: Michael Neale
>         Assigned To: Edson Tirelli
>
> In DefaultExpanderTest I have added a method:
> FIXME_testExpanderFailure()
> This shows a drl which should fail.
> eg if "foo" expands to "Foo()", then "foos" should NOT expand to "Foo()s" - it should be an error I believe (correct me if wrong).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira