[jboss-jira] [JBoss JIRA] Resolved: (JBPORTAL-1366) LDAPStaticGroupMembershipModuleImpl membershipAttributeIsDN Problem

[Boleslaw Dawidowicz (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBPORTAL-1366?page=all ]

Boleslaw Dawidowicz resolved JBPORTAL-1366.
-------------------------------------------

    Resolution: Done

Thanks for finding this. 

Now its covered by proper test cases for both LDAPStaticGroupMembershipModuleImpl and LDAPStaticRoleMembershipModuleImpl. 

CR2 is already tagged so this should go into final. Present in svn trank.

> LDAPStaticGroupMembershipModuleImpl membershipAttributeIsDN Problem
> -------------------------------------------------------------------
>
>                 Key: JBPORTAL-1366
>                 URL: http://jira.jboss.com/jira/browse/JBPORTAL-1366
>             Project: JBoss Portal
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Portal Identity
>    Affects Versions: 2.6.Beta1
>         Environment: Debian Linux Etch, java version "1.5.0_11"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_11-b03)
> Java HotSpot(TM) Client VM (build 1.5.0_11-b03, mixed mode, sharing)
>            Reporter: Matt Petteys
>         Assigned To: Boleslaw Dawidowicz
>             Fix For: 2.6 Final
>
>
> When i enter the portal admin, view the roles, and select view membership.  An error is generated that says, "Wrong dn format: mpetteys" where mpetteys is the uid in the memberUid attribute of the ldap group.  I have the MembershipModule configured per the below.
> <option>
> <name>membershipAttributeIsDN</name>
> <value>false</value>
> </option>
> The error is..
> 2007-04-28 21:25:12,414 DEBUG [org.jboss.portal.identity.ldap.LDAPStaticGroupMembershipModuleImpl] findUsers(): role = cn=user,ou=groups,ou=JbossPor$
> 2007-04-28 21:25:12,442 ERROR [org.jboss.portal.portlet.container.org_jboss_portal_core_portlet_role_RolePortlet] The portlet threw an exception
> java.lang.IllegalArgumentException: Wrong dn format: mpetteys
>         at org.jboss.portal.identity.ldap.helper.LDAPTools.stripDnToName(LDAPTools.java:53)
>         at org.jboss.portal.identity.ldap.LDAPStaticGroupMembershipModuleImpl.getUsers(LDAPStaticGroupMembershipModuleImpl.java:180)
>         at org.jboss.portal.identity.ldap.LDAPStaticGroupMembershipModuleImpl.findRoleMembers(LDAPStaticGroupMembershipModuleImpl.java:402)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:585)
>         at org.jboss.mx.interceptor.ReflectedDispatcher.invoke(ReflectedDispatcher.java:155)
>         at org.jboss.mx.server.Invocation.dispatch(Invocation.java:94)
>         at org.jboss.mx.interceptor.AbstractInterceptor.invoke(AbstractInterceptor.java:133)
>         at org.jboss.mx.server.Invocation.invoke(Invocation.java:88)
>         at org.jboss.mx.interceptor.ModelMBeanOperationInterceptor.invoke(ModelMBeanOperationInterceptor.java:142)
>         at org.jboss.mx.server.Invocation.invoke(Invocation.java:88)
>         at org.jboss.mx.server.AbstractMBeanInvoker.invoke(AbstractMBeanInvoker.java:264)
>         at org.jboss.mx.server.MBeanServerImpl.invoke(MBeanServerImpl.java:659)
>         at org.jboss.mx.util.MBeanProxyExt.invoke(MBeanProxyExt.java:210)
>         at $Proxy221.findRoleMembers(Unknown Source)
> This ties back to..
> http://anonsvn.jboss.org/repos/portal/tags/JBoss_Portal_2_6_0_BETA1/identity/src/main/org/jboss/portal/identity/ldap/LDAPStaticGroupMembershipModuleImpl.java
> In "Set getUsers(Role role, String userNameFilter) throws IdentityException" is the following code segment
> //if user is pointed as DN get only it's name
> if (!isUidAttributeIsDN())
> {
> 	name = LDAPTools.stripDnToName(name);
> 	users.add(getUserModule().findUserByUserName(name));
> }
> else
> {
> 	users.add(getUserModule().findUserByDN(name));
> }
> I think the not should be removed from the if.  If it is DN then stripDnToName should be used.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira