[jboss-jira] [JBoss JIRA] Updated: (JBMESSAGING-850) Start connection factories from LocalTestServer.startServerPeer() as they used to be

[Tim Fox (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBMESSAGING-850?page=all ]

Tim Fox updated JBMESSAGING-850:
--------------------------------

    Fix Version/s: 1.2.1.CR1
                       (was: Unscheduled)

> Start connection factories from LocalTestServer.startServerPeer() as they used to be
> ------------------------------------------------------------------------------------
>
>                 Key: JBMESSAGING-850
>                 URL: http://jira.jboss.com/jira/browse/JBMESSAGING-850
>             Project: JBoss Messaging
>          Issue Type: Task
>          Components: Tests and Performance
>            Reporter: Ovidiu Feodorov
>         Assigned To: Clebert Suconic
>            Priority: Minor
>             Fix For: 1.2.1.CR1
>
>
> Ovidiu wrote:
>  Your latest changes broke this convention, you deploy/start ConnectionFactories outside startServerPeer().  
>  Specifically, you deploy stuff specified in "server/default/deploy/connection-factories-service.xml" in 
>  ServiceContainer.startDatasource() (I renamed it temporarily startConnectionFactories()). 
> Clebert wrote:
>  I considered ConnectionFactory as part of the services started, and as ServerPeer would be also a 
>  Service I thought about making the refactoring.
> Ovidiu wrote:
>  ConnectionFactory are services, that is true, but it doesn't make any sense to deploy and start a 
>  connection factory unless you have a messaging server running. ServerPeer is also a service, 
>  and all of them are happily deployed together in startServerPeer(). Or at least they used to.
> Clebert wrote:
>  Besides, the parameter to start the HTTPConnectionFactory is set on ServiceContainer 
>  (boolean httpConnectionFactory), as this is cross-referenced with the start of Remoting.
> Ovidiu wrote:
>  Fine. Use a variable and pass that variable to startServerPeer().
> Clebert wrote:
>  If you like I could refactor the method back to LocalServer.
> Ovidiu wrote:
> Yes, please

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira