[jboss-jira] [JBoss JIRA] Commented: (JBREM-783) Remove network i/o from synch blocks that establish and terminate LeasePingers

[Ron Sigal (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBREM-783?page=comments#action_12370815 ] 
            
Ron Sigal commented on JBREM-783:
---------------------------------

Changes have been made to MicroRemoteClientInvoker.establishLease(), terminateLease(), and org.jboss.remoting.LeasePinger.  

establishLease() has been changed so that the first org.jboss.remoting.Client to call establishLease() and see LeasePinger == null becomes responsible for creating LeasePinger.  All other Client's wait until the first Client informs them that LeasePinger has been created.  Once the job of creating the LeasePinger has been assigned, the Client with that responsibility can exit the synchronization block before doing any network i/o.

The changes to terminateLease() are based on changes to LeasePinger, where the network i/o in removeClient() has been moved to a new method, disconnectClient().  terminateLease() calls removeClient() inside the synchronization block and disconnectClient() outside the synchronization block.

Unit test:  org.jboss.test.remoting.lease.synchronization.MultipleClientSynchronizationTestCase.

> Remove network i/o from synch blocks that establish and terminate LeasePingers
> ------------------------------------------------------------------------------
>
>                 Key: JBREM-783
>                 URL: http://jira.jboss.com/jira/browse/JBREM-783
>             Project: JBoss Remoting
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.4.0.Beta1 (Pinto), 2.2.0.SP4, 2.2.0.SP4_CP02, 2.2.1.SP1
>            Reporter: Ron Sigal
>         Assigned To: Ron Sigal
>             Fix For: 2.4.0.Beta1 (Pinto), 2.2.0.SP4_CP02, 2.2.1.SP1
>
>
> org.jboss.remoting.MicroRemoteClientInvoker.establishLease() and MicroRemoteClientInvoker.terminateLease() do network i/o in a synchronization block.  The synchronization should be reorganized to avoid that.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira