[jboss-jira] [JBoss JIRA] Commented: (JBREM-782) Remove network i/o from synch block in ServerInvokerCallbackHandler.getCallbackHandler()

[Ron Sigal (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBREM-782?page=comments#action_12370825 ] 
            
Ron Sigal commented on JBREM-782:
---------------------------------

The solution is just to break up the synchronization blocks in getCallbackHandler() into two blocks, without the call to the ServerIinvokerCallbackHandler constructor.

The fix has been applied to the remoting_2_2_0_GA branch.

There is no specific unit test.

> Remove network i/o from synch block in ServerInvokerCallbackHandler.getCallbackHandler()
> ----------------------------------------------------------------------------------------
>
>                 Key: JBREM-782
>                 URL: http://jira.jboss.com/jira/browse/JBREM-782
>             Project: JBoss Remoting
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.4.0.Beta1 (Pinto), 2.2.0.SP4, 2.2.0.SP4_CP02, 2.2.1.SP1
>            Reporter: Ron Sigal
>         Assigned To: Ron Sigal
>             Fix For: 2.4.0.Beta1 (Pinto), 2.2.0.SP4_CP02, 2.2.1.SP1
>
>
> org.jboss.remoting.ServerInvoker.getCallbackHandler() has a call to the org.jboss.remoting.callback.ServerInvokerCallbackHandler() constructor inside a synchronization block.,  ServerInvokerCallbackHandler creates an org.jboss.remoting.Client, which creates a client invoker, and, depending on the transport, the call to Client.connect() might involve network i/o.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira