[jboss-jira] [JBoss JIRA] Commented: (JBREM-767) Avoid deadlock in callback BisocketClientInvoker when timeout == 0

[Ron Sigal (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBREM-767?page=comments#action_12371144 ] 
            
Ron Sigal commented on JBREM-767:
---------------------------------

One fix for this issue is to move network i/o from the BisocketClientInvoker constructor to BisocketClientInvoker.handleCconnect() - JBREM-787.

Another fix is to have BisocketClientInvoker.handleDisconnect() wake up any threads waiting in BisocketClientInvoker.createSocket().  

The fix for the latter has been applied to branch remoting_2_2_0_GA.

Unit test: org.jboss.test.remoting.transport.bisocket.CallbackDisconnectTestCase.

> Avoid deadlock in callback BisocketClientInvoker when timeout == 0
> ------------------------------------------------------------------
>
>                 Key: JBREM-767
>                 URL: http://jira.jboss.com/jira/browse/JBREM-767
>             Project: JBoss Remoting
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.4.0.Beta1 (Pinto), 2.2.1.GA, 2.2.1.SP1
>            Reporter: Ron Sigal
>         Assigned To: Ron Sigal
>             Fix For: 2.4.0.Beta1 (Pinto), 2.2.0.SP4_CP02, 2.2.1.SP1
>
>
> If timeout == 0 then org.jboss.remoting.transport.bisocket.BisocketClientInvoker.createSocket() can hang forever if the client side is unavailable.  
> One fix is to not set timeout to 0, but currently the timeout value is inherited from the server invoker, for which timeout == 0 might be appropriate.  One solution is to implement a separate timeout parameter for callback client invokers (JBREM-765).
> Another fix is for PingTimeTask to notify a thread waiting in createSocket() when an attempt to send a PING to the client fails.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira