[jboss-jira] [JBoss JIRA] Commented: (GPD-78) configInfoElements of semantic elements are not always added to XML adapters

[Imran Naqvi (JIRA)]

    [ http://jira.jboss.com/jira/browse/GPD-78?page=comments#action_12371556 ] 
            
Imran Naqvi commented on GPD-78:
--------------------------------

I just tested with the new code and I'm afraid the problem still exists. GenericElements (formerly ConfigInfoElements) are not added to an Action. The fix for this is commented out in ActionDomAdapter.initialize()
The following lines of code in that method are commented out:
//			GenericElement[] genericElements = action.getGenericElements();
//			for (int i = 0; i < genericElements.length; i++) {
//				addElement(genericElements[i]);
//			}

If we uncomment this it should work. We need similar code in GenericElementXmlAdapter.initialize()
A sample process definition to reproduce this problem is:
<?xml version="1.0"?> 

<process-definition name="Movie" version="11"> 
<start-state name="Start"> 
<transition to="Get MPEG Properties" /> 
</start-state> 
<node name="Get MPEG Properties"> 
<action class="SomeActionHandler"><send>010901</send> 
<keys> 
<entry> 
                                            <key>VarName</key> 
                                            <value>1122</value> 
                                </entry> 
</keys> 
<receive> 
<element>030101</element> 
<element>030102</element> 
</receive> 
</action> 
<transition to="End"/> </node> 
<end-state name="End" /> 

The GenericElements in the Action in the above process definition never get added.

> configInfoElements of semantic elements are not always added to XML adapters
> ----------------------------------------------------------------------------
>
>                 Key: GPD-78
>                 URL: http://jira.jboss.com/jira/browse/GPD-78
>             Project: JBoss jBPM GPD
>          Issue Type: Bug
>          Components: jpdl
>    Affects Versions: jBPM JPDL Designer 3.1.0.beta2
>            Reporter: John Ruud
>         Assigned To: Koen Aers
>             Fix For: jBPM JPDL Designer 3.1.0.CR
>
>         Attachments: GPD-78.patch
>
>
> For example, if a node that contains an Action with a non-empty configInfoElements collection is added to the diagram, the configInfoElements collection is not assigned in the ActionDomAdapter. 
> I added the following line to the end of the "if (action != null)" clause in ActionDomAdapter.initialize(): 
> addElements(action.getConfigInfoElements()); 
> .. and then things seems to work. I believe this is similar to for example how the events collection is currently initialized in DecisionDomAdapter.initialize(), while of course there may be side effects that I'm not aware of. 
> It would be great if a fix (possibly the one described above) can be included in GD 3.1.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira