[jboss-jira] [JBoss JIRA] Commented: (JBPORTAL-1524) PageCustomizerInterceptor : regionName may be set in service descriptor.

[Antoine Herzog (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBPORTAL-1524?page=comments#action_12372455 ] 
            
Antoine Herzog commented on JBPORTAL-1524:
------------------------------------------

On my opinion : 

"It would break the current themes for people upgrading" : the sooner, the better : later, it will be "to late, there are to many people relying on ...

This code is introducing a "special way of building a region of the page".
It uses a "region", but it is not using a Portlet

very confusing when looking at all this 
not easy to search (grep) thing in the code, with only "dashboard" as key word

"internal code", "developers they just have to care about" :
for out of the box, and for mini customization.

from my experience : for any real portal in prod in a company, the dev + prod people will not just care only about changing a JSP.
They want to see what is going on in this part of the screen, and especially on the login feature.

well, all this is not vital.... it will work out of the box.
My proposal is to help dev people to have :
 - a quicker understanding of how all this work
 - a better way to customize this... as I needed first place 

help customize... help to make portal for prod.



> PageCustomizerInterceptor : regionName may be set in service descriptor.
> ------------------------------------------------------------------------
>
>                 Key: JBPORTAL-1524
>                 URL: http://jira.jboss.com/jira/browse/JBPORTAL-1524
>             Project: JBoss Portal
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>          Components: Portal Core
>    Affects Versions: 2.6 CR3, 2.6 Final
>         Environment: JBP 2.6 CR3
>            Reporter: Antoine Herzog
>         Assigned To: Thomas Heute
>             Fix For: 2.6.2 Final
>
>         Attachments: PageCustomizerInterceptor - Patch.zip
>
>
> About the PageCustomizerInterceptor : the 2 regionName may be set in service descriptor.
> It is more customizable, when building/adapting a layout.
> But the best of this is to understand better that this service is providing the content for the two regions in the layout.
> When looking at the layout, you can see the regionName='dashboardnav' defined for the header... 
> But no region of this name in default-object.xml or pages descriptors !
> After some file search, I found this label (dashboardnav) in the PageCustomizerInterceptor.
> It is not easy to understand what's going on in this service...
> As this jsp injection is not very usual, it would be much more easy to understand what's hapening if the region name would be customizable in the service descriptor.
> It also allow to change the names in the layout jsp file : navigation is a word that is in many place in the portal code and descriptor... not easy to follow the track of where are things about these tabs.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira