[jboss-jira] [JBoss JIRA] Commented: (JBREM-783) Remove network i/o from synch blocks that establish and terminate LeasePingers

[Ron Sigal (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBREM-783?page=comments#action_12372815 ] 
            
Ron Sigal commented on JBREM-783:
---------------------------------

The changes to org.jboss.remoting.MicroRemoteClientInvoker and org.jboss.remoting.LeasePinger introduced a race condition. Each PING sends the list of all current client leases, which is used to update the list of clients leases in org.jboss.remoting.Lease.  It is possible for one thread to send a PING with a client list from which a client lease has been removed and for that list to arrive before the server gets the request to terminate that lease.

> Remove network i/o from synch blocks that establish and terminate LeasePingers
> ------------------------------------------------------------------------------
>
>                 Key: JBREM-783
>                 URL: http://jira.jboss.com/jira/browse/JBREM-783
>             Project: JBoss Remoting
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.4.0.Beta1 (Pinto), 2.2.0.SP4, 2.2.0.SP4_CP02, 2.2.1.SP1
>            Reporter: Ron Sigal
>         Assigned To: Ron Sigal
>             Fix For: 2.4.0.Beta1 (Pinto), 2.2.0.SP4_CP02, 2.2.1.SP1
>
>
> org.jboss.remoting.MicroRemoteClientInvoker.establishLease() and MicroRemoteClientInvoker.terminateLease() do network i/o in a synchronization block.  The synchronization should be reorganized to avoid that.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira