[jboss-jira] [JBoss JIRA] Commented: (JBREM-794) LeasePinger.addClient() should not create a new LeaseTimerTask if none currently exists

[Ron Sigal (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBREM-794?page=comments#action_12373433 ] 
            
Ron Sigal commented on JBREM-794:
---------------------------------

Change applied for release 2.2.2.GA and on branch remoting_2_x.

Unit test:  org.jboss.test.remoting.lease.UniquePingerTaskTestCase.

> LeasePinger.addClient() should not create a new LeaseTimerTask if none currently exists
> ---------------------------------------------------------------------------------------
>
>                 Key: JBREM-794
>                 URL: http://jira.jboss.com/jira/browse/JBREM-794
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.2.0.SP4, 2.2.1.GA, 2.4.0.Beta1 (Pinto)
>            Reporter: Ron Sigal
>         Assigned To: Ron Sigal
>             Fix For: 2.2.2.GA, 2.4.0.Beta1 (Pinto)
>
>
> When org.jboss.remoting.LeasePinger.addClient() adds a new org.jboss.remoting.Client with a shorter ping period, it restarts the LeaseTimerTask.  However, org.jboss.remoting.MicroRemoteClientInvoker.establishLease() calls LeasePinger.addClient() before it calls LeasePinger.startPing().  LeasePinger incorrectly creates a LeaseTimerTask in addClient() and then creates a second one in startPing().
> LeasePinger.addClient() should be changed so that it starts a new LeaseTimerTask only if one already exists.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira