[jboss-jira] [JBoss JIRA] Commented: (JBRULES-1133) Janino and eclipse compiler might need to be optional for 4.1

[Geoffrey De Smet (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBRULES-1133?page=comments#action_12373856 ] 
            
Geoffrey De Smet commented on JBRULES-1133:
-------------------------------------------

[22:18] <conan> yes it would be unwise to change it now
[22:18] <conan> people can still exclude
[22:18] <ge0ffrey> in worst case, they can start doing <exclusions>... as this isn't a clear optional dep I 'd leave it like this for now


> Janino and eclipse compiler might need to be optional for 4.1
> -------------------------------------------------------------
>
>                 Key: JBRULES-1133
>                 URL: http://jira.jboss.com/jira/browse/JBRULES-1133
>             Project: JBoss Rules
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Drl Parser/Builder
>    Affects Versions:  4.0.0.GA
>            Reporter: Geoffrey De Smet
>         Assigned To: Geoffrey De Smet
>            Priority: Minor
>             Fix For: FUTURE
>
>
> I didn't want to make this change for 4.0.x as it would require our users to put a direct dependency on either janino or eclipse-compiler.
> Drools-compiler needs one of both.
> Currently users get bloated with a transitive dependency on both.
> Making them optional would force them to make a dependency on one of the themselves... which makes the "hello world" program harder.
> As it would also force jbrms's etc tests to choose one.
> Why shouldn't do this before 4.1, if we even want to do this.
> What do you think?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira