[jboss-jira] [JBoss JIRA] Closed: (JBREM-774) BisocketClientInvoker.replaceControlSocket() and handleDisconnect() should close control socket

[Ron Sigal (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBREM-774?page=all ]

Ron Sigal closed JBREM-774.
---------------------------

    Resolution: Done

The fix has been applied to branch remoting_2_x, and the unit test passes on cruisecontrol.

> BisocketClientInvoker.replaceControlSocket() and handleDisconnect() should close control socket
> -----------------------------------------------------------------------------------------------
>
>                 Key: JBREM-774
>                 URL: http://jira.jboss.com/jira/browse/JBREM-774
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.4.0.Beta1 (Pinto), 2.2.0.SP4, 2.2.1.GA
>            Reporter: Ron Sigal
>         Assigned To: Ron Sigal
>             Fix For: 2.2.2.GA, 2.4.0.Beta1 (Pinto)
>
>
> If cpu overload or network congestion causes a control connection PING to get delayed, the client side org.jboss.remoting.transport.bisocket.Bisocket.BisocketServerInvoker.ControlMonitorTimerTask will tell the server side BisocketServerInvoker.SecondaryServerSocketThread to replace the control socket.  
> If org.jboss.remoting.transport.bisocket.Bisocket.BisocketClientInvoker.replaceControlSocket() does not close the old control socket, and if the client is still alive, the client side BisocketServerInvoker.ControlConnectionThread will be blocked trying to read from an old control connection, which is no longer in use on the server side.
> Also, BisocketClientInvoker.handleDisconnect() should close the control socket.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira