[jboss-jira] [JBoss JIRA] Commented: (JBMESSAGING-1183) Message Bridge use QueueFactoryRef or TopicFactoryRef instead of FactoryRef when looking up Source and Target Connection Factories

[Aaron Walker (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBMESSAGING-1183?page=comments#action_12390850 ] 
            
Aaron Walker commented on JBMESSAGING-1183:
-------------------------------------------

I don't have a diff tool to create a patch but here are the line of code for BridgeService.java. The last two line are the original lines of code just replacing the strings this the two variables about line 327 in original souce file for 1.4.0.SP1

      String sourceFactoryRef = "QueueFactoryRef";
      if(sourceDest instanceof javax.jms.Topic)
      {
        sourceFactoryRef = "TopicFactoryRef";
      }
	  
	  String targetFactoryRef = "QueueFactoryRef";
      if(targetDest instanceof javax.jms.Topic)
      {
        targetFactoryRef = "TopicFactoryRef";
      }
            
      String sourceCFRef = (String)server.getAttribute(sourceProviderLoader, sourceFactoryRef);
      
      String targetCFRef = (String)server.getAttribute(targetProviderLoader, targetFactoryRef);

> Message Bridge use QueueFactoryRef or TopicFactoryRef instead of FactoryRef when looking up Source and Target Connection Factories
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBMESSAGING-1183
>                 URL: http://jira.jboss.com/jira/browse/JBMESSAGING-1183
>             Project: JBoss Messaging
>          Issue Type: Bug
>          Components: Messaging Core
>    Affects Versions: 1.4.0.SP1
>            Reporter: Aaron Walker
>         Assigned To: Aaron Walker
>            Priority: Minor
>
> Some message providers don't have a single base class the implements both the Queue and Topic Connection Factories so you can't create a single JMSProviderLoader where you can set the FactoryRef attribute to a single JNDI name. Really the Message bridge should use the QueueFactoryRef or TopicFactoryRef attribute depending on the destination type that the bridge is trying to connect to.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira