[jboss-jira] [JBoss JIRA] Commented: (JBAS-5073) fix build authenticated proxy (there seems to have been a cut and paste error at some point)

[Andrew Oliver (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBAS-5073?page=comments#action_12393269 ] 
            
Andrew Oliver commented on JBAS-5073:
-------------------------------------

the <condition> element was not inside of the target.  look at the patch.  It meant that if you supplied a user/password ... it was ignored.  IT is a one line fix.  I don't know why ant lets you randomly stick <condition> tags outside of where they are interpreted but apparently it does.  

well I have a little consulting side business and do subcontracting for RH among others so it often involves JBoss and building JBoss stuff on frustrating networks with frustrating proxies.  You can't imagine the joy of building JBoss behind an NTLM authenticated proxy.  I even had to patch ntlmaps which is defunct but has a buffering bug that makes it not work on slow networks...  

BTW is 4.4 an active branch?  Should I have applied it there?

> fix build authenticated proxy (there seems to have been a cut and paste error at some point)
> --------------------------------------------------------------------------------------------
>
>                 Key: JBAS-5073
>                 URL: http://jira.jboss.com/jira/browse/JBAS-5073
>             Project: JBoss Application Server
>          Issue Type: Patch
>      Security Level: Public(Everyone can see) 
>          Components: Build System
>    Affects Versions: JBossAS-4.2.1.GA, JBossAS-4.2.0.GA, JBossAS-4.2.2.GA
>            Reporter: Andrew Oliver
>         Assigned To: Rajesh Rajasekaran
>             Fix For: JBossAS-4.2.3.GA
>
>         Attachments: jboassas-proxy.patch
>
>
> The condition for setting proxy authentication is outside of the task which causes the condition to not set a value.  This moves it inside the task.  Following this proxy authentication works as expected.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira