[jboss-jira] [JBoss JIRA] Commented: (JBREM-786) stale sockets can be gotten from pool even with current rety logic

[Ron Sigal (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBREM-786?page=comments#action_12393536 ] 
            
Ron Sigal commented on JBREM-786:
---------------------------------

Unit test: org.jboss.test.remoting.transport.socket.connectionpool.ConnectionPoolRetryTestCase.  Restricts number of org.jboss.remoting.transport.socket.ServerThread's to 2 and runs invocations from multiple threads, creating a situation in which ServerThreads are frequently evicted and reused with new sockets, so that there is a high probability that connections in the client side connection pool will be stale.

> stale sockets can be gotten from pool even with current rety logic
> ------------------------------------------------------------------
>
>                 Key: JBREM-786
>                 URL: http://jira.jboss.com/jira/browse/JBREM-786
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: transport
>    Affects Versions: 1.4.6.GA
>            Reporter: james ahlborn
>         Assigned To: Ron Sigal
>             Fix For: 2.4.0.Beta1 (Pinto)
>
>         Attachments: remoting-fixes.txt
>
>
> The retry logic in SocketClientInvoker.transport attempts to ensure that the invoker does not get a stale socket on the last attempt by flushing the pool.  however, this only discards any currently unused scokets.  a second invoker could return a stale socket after the flush, causing the first invoker to fail again on the last retry (with an EOFException).  while this seems like an edge case, we can hit it reliably under load with many connections to the same destination.  i've patched this class so that the last call to getConnection will never return a pooled connection.  we never got the EOFException after applying this fix.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira