[jboss-jira] [JBoss JIRA] Closed: (JBREM-889) If an exception occurs during invocation, usedPooled is not decremented, thus leading into eventual remoting failures

[Ron Sigal (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBREM-889?page=all ]

Ron Sigal closed JBREM-889.
---------------------------

    Resolution: Won't Fix
      Assignee: Ron Sigal

Hi Hasan,

Thank you for your contribution.  In fact, we recently ripped out the usedPooled code in favor of a semaphore approach (thanks to Tim Fox), so what you're experiencing shouldn't be a problem any more.  The change is currently available in Remoting release 2.2.2.SP4 (http://repository.jboss.com/jboss/remoting/2.2.2.SP4-brew/) and has been applied for the upcoming release 2.4.0.Beta1.

> If an exception occurs during invocation, usedPooled is not decremented, thus leading into eventual remoting failures 
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBREM-889
>                 URL: http://jira.jboss.com/jira/browse/JBREM-889
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: transport
>    Affects Versions: 2.2.2.SP1
>         Environment: Should for all environments
>            Reporter: Hasan Ceylan
>         Assigned To: Ron Sigal
>         Attachments: remoting.patch, remoting.patch
>
>
> Hello,
> I guess this goes into Ron's area. Back in 2004 we had had a similar issue.
> :)
> In MicroSocketClientInvoker.transport(), having obtained a socket, if an exception occurs during the invocation, the code that decrements usedPooled never gets called thus inflating overtime. Eventually reaches 50, the hard limit which in turn, makes clients unable to obtain a socket from pool or create a new one. 
> I guess, a try, finally block is needed starting right after successful socket acquired,   till where you decrement the usedPooled (marked with // Put socket back in pool for reuse).
> This will make sure the usedPooled is decremented.
> I searched the JIRA and also found similar bug reports which I believe all should be related. 
> Regards,
> Hasan Ceylan

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira