[jboss-jira] [JBoss JIRA] Commented: (JBMESSAGING-818) HTTP transport sends zero length lists of polled callbacks

[Tim Fox (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBMESSAGING-818?page=comments#action_12353795 ] 
            
Tim Fox commented on JBMESSAGING-818:
-------------------------------------

By the nature of polling it is inevitable that sometimes there will be nothing to return.

Either null or an empty list can be returned. I don't see the problem with returning an empty list.

> HTTP transport sends zero length lists of polled callbacks
> ----------------------------------------------------------
>
>                 Key: JBMESSAGING-818
>                 URL: http://jira.jboss.com/jira/browse/JBMESSAGING-818
>             Project: JBoss Messaging
>          Issue Type: Bug
>    Affects Versions: 1.2.0.Beta2
>            Reporter: Tim Fox
>         Assigned To: Ron Sigal
>             Fix For: 1.2.0.GA
>
>
> I have noticed that, at times, with the HTTP transport, the wireformat receives a list of polled callbacks of length zero.
> This results in a pointless callback delivery being made from the server to the client.
> This can be easily seen by adding the following logging to JMSWireformat:
>     else if (param instanceof List)
>             {
>                // List of polled Callbacks, this is how messages are delivered when using
>                // polled callbacks e.g. the HTTP transport
>                
>                //Sanity check
>                if (((List)param).isEmpty())
>                {
>                   log.error("Got a polled callback list - but it is empty!!!");
>                }
> And then running the test suite. I notice most of these when running the crash tests.
>                

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira