[jboss-jira] [JBoss JIRA] Created: (JBPM-848) Incorrect mail.smtp.host property + configurable mail from address

[Bruno Dumon (JIRA)]

Incorrect mail.smtp.host property + configurable mail from address
------------------------------------------------------------------

                 Key: JBPM-848
                 URL: http://jira.jboss.com/jira/browse/JBPM-848
             Project: JBoss jBPM
          Issue Type: Patch
          Components: Core Engine
    Affects Versions: jBPM jPDL 3.2 beta 2
            Reporter: Bruno Dumon
         Assigned To: Tom Baeyens


jBPM incorrectly sets "jbpm.mail.smtp.host" instead of "mail.smtp.host" in the properties passed to JavaMail. As a consequence, JavaMail always tries to send to localhost. It seems this was introduced by accident here:
http://fisheye.jboss.com/browse/JBPM/jbpm.3/src/java.jbpm/org/jbpm/mail/Mail.java?r1=1.4&r2=1.5

The attached patch fixes this.

Also, the from address for mails is currently hardcoded to "jbpm at noreply". Many SMTP servers don't allow an invalid origin domain name (as do many spam filters), this is the exception I get:

javax.mail.SendFailedException: Sending failed;
  nested exception is:
        class javax.mail.SendFailedException: Invalid Addresses;
  nested exception is:
        class javax.mail.SendFailedException: 450 <jbpm at noreply>: Sender address rejected: Domain not found

The attached patch also makes the from address configurable via jbpm.cfg.xml.

Patches are against current CVS and taken with the jbpm.3/jpdl directory as root.

Thanks for taking the time to look at this.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira