[jboss-jira] [JBoss JIRA] Commented: (JBREM-662) Failed ClientInvoker not cleaned up properly

[Tom Elrod (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBREM-662?page=comments#action_12351058 ] 
            
Tom  Elrod commented on JBREM-662:
----------------------------------

Per Ron:

Ok, I think I've got it.  ConnectionValidator.checkConnection() gets a pointer (oops, C++) to the configuration map from the Client, so when it adds the extra parameters (timeout, etc), it adds them to the Client's configuration Map, and also adds them to the configuration Map stored in the holder on the clientLocators Map in InvokerRegistry.  Consequently, when ConnectionValidator goes to get a "new" client invoker, it gets a match on the existing client invoker, which has timeout and NumberOfRetries already set.

I've changed ConnectionValidator to make a copy of the Client's configuration Map.  The existing unit tests that reference ConnectionListener continue to work.  I tried to write a new unit test to verify that ConnectionValidator is creating a new client invoker, but then I noticed that the new invoker gets destroyed after it's used, so it's hard to see how to capture the fact that it was created. 

> Failed ClientInvoker not cleaned up properly
> --------------------------------------------
>
>                 Key: JBREM-662
>                 URL: http://jira.jboss.com/jira/browse/JBREM-662
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.2.0.Alpha4
>            Reporter: Ovidiu Feodorov
>         Assigned To: Tom  Elrod
>             Fix For: 2.2.0.Alpha5, 2.2.0.Alpha6
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira