[jboss-jira] [JBoss JIRA] Created: (JBAS-4010) XATerminator interrface of TxManager is not including error codes in XAExceptions thrown

[Adrian Brock (JIRA)]

XATerminator interrface of TxManager is not including error codes in XAExceptions thrown
----------------------------------------------------------------------------------------

                 Key: JBAS-4010
                 URL: http://jira.jboss.com/jira/browse/JBAS-4010
             Project: JBoss Application Server
          Issue Type: Task
      Security Level: Public (Everyone can see)
          Components: JCA service
    Affects Versions: JBossAS-4.0.5.GA
            Reporter: Adrian Brock
         Assigned To: Weston Price
         Attachments: XAException.diff

According to the javadoc for XATerminator, it should include an error code in the XAException thrown:
e.g. see
http://java.sun.com/j2ee/1.4/docs/api/javax/resource/spi/XATerminator.html#prepare(javax.transaction.xa.Xid)

This is similar to the fix for the JBossXALocalException done in JBAS-2807

However, our XATerminator impl in TxManager is not including the error code in the thrown XAException.

I'm attaching a diff that shows how to fix this for prepare(), i.e. add XA_RBROLLBACK
but this also needs doing for the other methods commit/forget/rollback
and tests creating to prevent regression.



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira