[jboss-jira] [JBoss JIRA] Created: (JBCACHE-948) Patch to add return value (boolean) to removeChild*() and removeNode*() methods

[Elias Ross (JIRA)]

Patch to add return value (boolean) to removeChild*() and removeNode*() methods
-------------------------------------------------------------------------------

                 Key: JBCACHE-948
                 URL: http://jira.jboss.com/jira/browse/JBCACHE-948
             Project: JBoss Cache
          Issue Type: Patch
      Security Level: Public (Everyone can see)
    Affects Versions: 2.0.0.ALPHA2, 2.0.0.ALPHA1
            Reporter: Elias Ross
         Assigned To: Manik Surtani
         Attachments: remove.patch

It is useful to know if a node was actually removed or not. Having a return value adds a bit of usefulness. A boolean return value is consistent with Collections.remove().

In any case, it's a small but potentially useful API change which I suggest for 2.0 release.

For example, in CacheImpl, there was no way to detect removal failures:

void _remove() ...
               try
               {
                  _remove(tx, tmp, create_undo_ops, true, eviction);
               }
               catch (Exception e)
               {
                  log.error("failure removing node " + tmp);
               }

The patch includes the changes and additional tests.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira