[jboss-jira] [JBoss JIRA] Created: (EJBTHREE-853) Partial StringProperty replacement in ejb 3 container

[Roland R?z (JIRA)]

Partial StringProperty replacement in ejb 3 container
-----------------------------------------------------

                 Key: EJBTHREE-853
                 URL: http://jira.jboss.com/jira/browse/EJBTHREE-853
             Project: EJB 3.0
          Issue Type: Feature Request
    Affects Versions: EJB 3.0 RC9 - FD
            Reporter: Roland R?z


I tried to change the messageSelector in an EJB 3.0 MDB in the ejb.jar.xml containing partial System Property references (aaa${xyz}bbb). Sadly this didn't work as with ejb 2.1.

I think fully supporting system property replacement as with ejb 2.x in EJB 3.0 would be a nice feature. 

The method org.jboss.ejb3.metamodel.EjbJarDDObjectFactory.getValue(String name, String value)  

could be changed to

{
   value = org.jboss.util.StringPropertyReplacer.replaceProperties(value); 
}


I would suggest, to implement the string property replacement even better in the class org.jboss.metamodel.descriptor.DDObjectFactory.getValue()

and remove the getValue method from JBossDDObjectFactory and EjbJarDDObjectFactory.


The idea of using an MBean abstraction to replace system properties is fine but the nice syntax of the StringPropertyReplacer should be still supported (${v1,v2:default}). Returning always the replaced property is one possibility (currently it is not done this way) but probably a new method "getReplaced" would be less surprising.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira