[jboss-jira] [JBoss JIRA] Commented: (JBRULES-214) goddamn keyword collisions damn it damn damn

[Edson Tirelli (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBRULES-214?page=comments#action_12351940 ] 
            
Edson Tirelli commented on JBRULES-214:
---------------------------------------

Most of the conflicts are solved in revision #9193. 

See following sample:

==================================
package test.rule.when.end.package.mine;

global java.lang.String accumulate;

function boolean eval() {
    return true;
}

rule type1
  when
	$id : Something( duration == "foo")
  then
  	The.end();
  	end;
  	attributes;
  	rule;
  	package;
end
===========================

Only case I was not able to solve yet is when the first word in a dotted name is a reserved word. For instance, the following will not work, because "rule" is the first word in the dotted name and is a reserved word.

import rule.mypackage.MyClass;

But the following works fine:

import org.rule.mypackage.MyClass;

I will investigate more for the final 3.2 release, but for 3.1 milestone 1 I will probably let as it is now.



> goddamn keyword collisions damn it damn damn
> --------------------------------------------
>
>                 Key: JBRULES-214
>                 URL: http://jira.jboss.com/jira/browse/JBRULES-214
>             Project: JBoss Rules
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Drl Parser/Builder
>    Affects Versions: 3.0-rc1
>            Reporter: Michael Neale
>         Assigned To: Edson Tirelli
>            Priority: Critical
>             Fix For: 3.1-m3
>
>
> Getting more complaints about collisions with keywords. Things like "end" are obvious, but even "duration" etc...
> Parser possibly needs to be a bit cleverer (not sure why duration is barfing.. but anyway).
> I guess the only clear way forward is to enforce newline characters.
> Most often the problem happens in the LHS. On the RHS its just "end" that is a problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira