[jboss-jira] [JBoss JIRA] Commented: (JBRULES-656) Parser Build is throwing Exceptions

[Michael Neale (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBRULES-656?page=comments#action_12367796 ] 
            
Michael Neale commented on JBRULES-656:
---------------------------------------

All the "throws" that is in the code I have reviewed, and believe it should stay there. 
Mainly they are malformed DSL and malformed RuleFlow.

That leaves the DRL.g itself throwing RuntimeExceptions - I don't think its wise to catch EVERY exception from the grammar (if someone does want to do that, then DrlParser is the place to do it - in which case we guarantee there will be no exception thrown - but really the IDE should deal with that I think).

Otherwise they are a bug, and need a test case to uncover. Catching all exceptions will simply make it take longer to notice the bug.

> Parser Build is throwing Exceptions
> -----------------------------------
>
>                 Key: JBRULES-656
>                 URL: http://jira.jboss.com/jira/browse/JBRULES-656
>             Project: JBoss Rules
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Drl Parser/Builder
>            Reporter: Mark Proctor
>         Assigned To: Edson Tirelli
>             Fix For:  4.0.0.MR4
>
>
> All exceptions, inclduing null pointers, should be caught wrapped and added to the errors list. We do not want the parser to exit eary due to an exception.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira