[jboss-jira] [JBoss JIRA] Commented: (JBPORTAL-1346) Improve the parameter value handling

[Julien Viet (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBPORTAL-1346?page=comments#action_12368073 ] 
            
Julien Viet commented on JBPORTAL-1346:
---------------------------------------

actually re reading the code, it is something in between:

the get() implementation on the multi value instead of returning the collection should rather return null if the collection is empty or the first element of the collection if it is not empty.



> Improve the parameter value handling
> ------------------------------------
>
>                 Key: JBPORTAL-1346
>                 URL: http://jira.jboss.com/jira/browse/JBPORTAL-1346
>             Project: JBoss Portal
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>          Components: Portal QA
>            Reporter: Julien Viet
>         Assigned To: Matt Wringe
>             Fix For: 2.8 Final
>
>
> we have :
> MonoValuedTestParameterValue extends TestParameterValue
> MultiValuedTestParameterValue extends TestParameterValue
> and 
> TestParameterValue { public abstract Object getValue(); }
> the method getValue() should not be here : a value is either mono valued or multi valued and both have nothing in common, the code client of that needs to deal with both of them explicitely.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira