[jboss-jira] [JBoss JIRA] Commented: (JBPORTAL-1524) PageCustomizerInterceptor : regionName may be set in service descriptor.

[Antoine Herzog (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBPORTAL-1524?page=comments#action_12368930 ] 
            
Antoine Herzog commented on JBPORTAL-1524:
------------------------------------------

yes, sorry, I wrote it to fast.

purpose : make customization more easy to understand.
and more generic.

A) Things : see attach files :
I wrote a class as a patch
The code change is marked by "AHG_PATCH" comment.
The class is not tested (I just wrote the change).

And a jboss-service.xml descriptor for the service.

In the jsp layout file : the two region names must be changed accordingly.

B) Details : 
I called these special region some "JspRegion".
(They are not regular portlet regions) 
I use this prefix, so it is more easy to search for those thing in the xml/java source files.

The window created for the jsp content have a name : "window_for_" +  jspRegionNameX

The doc will have to be adapted.



> PageCustomizerInterceptor : regionName may be set in service descriptor.
> ------------------------------------------------------------------------
>
>                 Key: JBPORTAL-1524
>                 URL: http://jira.jboss.com/jira/browse/JBPORTAL-1524
>             Project: JBoss Portal
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>          Components: Portal Core
>    Affects Versions: 2.6 CR3, 2.6 Final
>         Environment: JBP 2.6 CR3
>            Reporter: Antoine Herzog
>         Assigned To: Julien Viet
>             Fix For: 2.6.2 Final
>
>
> About the PageCustomizerInterceptor : the 2 regionName may be set in service descriptor.
> It is more customizable, when building/adapting a layout.
> But the best of this is to understand better that this service is providing the content for the two regions in the layout.
> When looking at the layout, you can see the regionName='dashboardnav' defined for the header... 
> But no region of this name in default-object.xml or pages descriptors !
> After some file search, I found this label (dashboardnav) in the PageCustomizerInterceptor.
> It is not easy to understand what's going on in this service...
> As this jsp injection is not very usual, it would be much more easy to understand what's hapening if the region name would be customizable in the service descriptor.
> It also allow to change the names in the layout jsp file : navigation is a word that is in many place in the portal code and descriptor... not easy to follow the track of where are things about these tabs.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira