[jboss-jira] [JBoss JIRA] Commented: (JBRULES-992) Optional dependencies not marked as optional in maven pom xmls

Wed Jul 25 08:33:47 EDT 2007

    [ http://jira.jboss.com/jira/browse/JBRULES-992?page=comments#action_12369989 ] 

Tuomas Kiviaho commented on JBRULES-992:
----------------------------------------

When excluding eclipse-jdt-core the PackageBuilder stops working since there are some runtime dependencies to these eclipse classes.

org.drools.RuntimeDroolsException: Unable to load dialect 'org.drools.rule.builder.dialect.java.JavaDialect:java'
	at org.drools.compiler.PackageBuilderConfiguration.buildDialectRegistry(PackageBuilderConfiguration.java:156)
	at org.drools.compiler.PackageBuilder.<init>(PackageBuilder.java:131)
	at org.drools.compiler.PackageBuilder.<init>(PackageBuilder.java:84)

It took me a while to figure this out since dialect registration ate the original exception leading to JDT.
java.lang.NoClassDefFoundError: org/eclipse/jdt/internal/compiler/env/INameEnvironment

> Optional dependencies not marked as optional in maven pom xmls
> --------------------------------------------------------------
>
>                 Key: JBRULES-992
>                 URL: http://jira.jboss.com/jira/browse/JBRULES-992
>             Project: JBoss Rules
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions:  4.0.0.MR3
>         Environment: Maven 2.0.7
>            Reporter: Tuomas Kiviaho
>         Assigned To: Mark Proctor
>
> Slimming <http://markproctor.blogspot.com/2007/05/jboss-rules-even-slimmer.html> could be taken even further by marking optional dependencies listed in <http://anonsvn.labs.jboss.com/labs/jbossrules/trunk/README_DEPENDENCIES.txt> with <optional>true<optional/>.
> This would effectively remove transitional dependencies by default. Now I have to exclude them manually as a workaround. 
> Having xerces and xml-apis as transitive dependencies reminds me of commons-logging 1.1 situation where container/JDK provided packages emerge in wrong places of classpath hierarchy. Here endorsement via provided scope is in my opinion more appropriate. XPP3 could probably be replaced with StaxDriver, thus replacing one dependency with JDK provided dependency, but this goes already into implementation details.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira