[jboss-jira] [JBoss JIRA] Commented: (JBREM-775) MicroSocketClientInvoker.initPool() should omit pool from log message

[Ron Sigal (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBREM-775?page=comments#action_12370349 ] 
            
Ron Sigal commented on JBREM-775:
---------------------------------

Instead of removing pool from the log statement, the log statement is synchronized.

The fix has been applied to branch remoting_2_2_0_GA.

> MicroSocketClientInvoker.initPool() should omit pool from log message
> ---------------------------------------------------------------------
>
>                 Key: JBREM-775
>                 URL: http://jira.jboss.com/jira/browse/JBREM-775
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.4.0.Beta1 (Pinto)
>            Reporter: Ron Sigal
>         Assigned To: Ron Sigal
>             Fix For: 2.4.0.Beta1 (Pinto)
>
>
> Clebert Suconic reports a ConcurrentModificationException:
> Producer:3 01:00:42,861 INFO  [SeveralClientsStressTest$Producer] Sending Exception
> java.util.ConcurrentModificationException
>         at java.util.LinkedList$ListItr.checkForComodification(LinkedList.java:617)
>         at java.util.LinkedList$ListItr.next(LinkedList.java:552)
>         at java.util.AbstractCollection.toString(AbstractCollection.java:453)
>         at java.lang.String.valueOf(String.java:2577)
>         at java.lang.StringBuffer.append(StringBuffer.java:220)
>         at org.jboss.remoting.transport.socket.MicroSocketClientInvoker.initPool(MicroSocketClientInvoker.java:715)
>         at org.jboss.remoting.transport.socket.MicroSocketClientInvoker.handleConnect(MicroSocketClientInvoker.java:450)
>         at org.jboss.remoting.transport.bisocket.BisocketClientInvoker.handleConnect(BisocketClientInvoker.java:269)
>         at org.jboss.remoting.MicroRemoteClientInvoker.connect(MicroRemoteClientInvoker.java:242)
>         at org.jboss.remoting.ConnectionValidator.start(ConnectionValidator.java:301)
>         at org.jboss.remoting.ConnectionValidator.addConnectionListener(ConnectionValidator.java:228)
>         at org.jboss.remoting.Client.addConnectionListener(Client.java:367)
>         at org.jboss.remoting.Client.addConnectionListener(Client.java:339)
>         at org.jboss.jms.client.remoting.JMSRemotingConnection.addConnectionListener(JMSRemotingConnection.java:379)
>         at org.jboss.jms.client.container.StateCreationAspect.handleCreateConnectionDelegate(StateCreationAspect.java:103)
>         at org.jboss.aop.advice.org.jboss.jms.client.container.StateCreationAspect0.invoke(StateCreationAspect0.java)
>         at org.jboss.jms.client.delegate.ClientConnectionFactoryDelegate$createConnectionDelegate_N3019492359065420858.invokeNext(ClientConnectionFactoryDelegate$createConnectionDelegate_N3019492359065420858.java)
>         at org.jboss.jms.client.delegate.ClientConnectionFactoryDelegate.createConnectionDelegate(ClientConnectionFactoryDelegate.java)
>         at org.jboss.jms.client.JBossConnectionFactory.createConnectionInternal(JBossConnectionFactory.java:205)
>         at org.jboss.jms.client.JBossConnectionFactory.createConnection(JBossConnectionFactory.java:87)
>         at org.jboss.jms.client.JBossConnectionFactory.createConnection(JBossConnectionFactory.java:82)
>         at org.jboss.test.messaging.jms.stress.SeveralClientsStressTest$Producer.run(SeveralClientsStressTest.java:324) 
> thrown in the line
>      log.debug(this + " using pool (" + pool + ") already defined for " + address);
> in org.jboss.remoting.transport.socket.MicroSocketClientInvoker.initPool().  pool is a java.util.LinkedList, and LinkedList.toString() iterates through the list elements.  These elements can be shared by multiple client invokers, and apparently another invoker modified the list while the log statement was running.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira