[jboss-jira] [JBoss JIRA] Closed: (JGRP-517) TP.send() creates a new ByteArrayOutputStream for every message

[Bela Ban (JIRA)]

     [ http://jira.jboss.com/jira/browse/JGRP-517?page=all ]

Bela Ban closed JGRP-517.
-------------------------

    Resolution: Rejected

I'm afraid I have to reject this proposal. Adding yey another flag adds to clutter, and reduces simplicity. I've run tests with a shared output stream (reset for each message) and the numbers were not better than creating a new output stream for each message.
Unless you show me a performance gain for reusing an output stream, I'm not going to implement this.


> TP.send() creates a new ByteArrayOutputStream for every message
> ---------------------------------------------------------------
>
>                 Key: JGRP-517
>                 URL: http://jira.jboss.com/jira/browse/JGRP-517
>             Project: JGroups
>          Issue Type: Task
>            Reporter: Michael Newcomb
>         Assigned To: Bela Ban
>             Fix For: 2.5
>
>
> Every call to TP.send() results in a new ByteArrayOutputStream being created. This creates a large amount of garbage. Could TP.send() use a pool of ByteArrayOutputStreams or something to cut down on generated garbage?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira