[jboss-jira] [JBoss JIRA] Created: (JBPM-981) Whitespace and line endings in script elements are not preserved - fix?

[Edward Staub (JIRA)]

Whitespace and line endings in script elements are not preserved - fix?
-----------------------------------------------------------------------

                 Key: JBPM-981
                 URL: http://jira.jboss.com/jira/browse/JBPM-981
             Project: JBoss jBPM
          Issue Type: Feature Request
          Components: Core Engine
    Affects Versions: jBPM jPDL 3.2
            Reporter: Edward Staub
         Assigned To: Tom Baeyens


The current Script implementation collapses script whitespace and eliminates line-endings in scripts - even when within a !CDATA. I believe this is often bad and never good, apart from trivial optimization.

Line-ending preservation is necessary for use of // comments.

Whitespace and line-ending preservation are useful for script compiler error messages that call out a line and column position of the error.
These positions are meaningless if space has been collapsed and line-endings removed.

I happen to be experimenting with using other script languages (especially Groovy) for which line endings are meaningful. You probably don't care about that, though!

The fix is easy: in Script.read(), replace both occurrences of getTextTrim() with getText().


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira