[jboss-jira] [JBoss JIRA] Commented: (JBAS-4487) Checking of Transaction Complete is missing rolled back transactions

[Adrian Brock (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBAS-4487?page=comments#action_12365582 ] 
            
Adrian Brock commented on JBAS-4487:
------------------------------------

I've committed fixes for BMT and Servlets to suspend any leftover transaction after it has checked/rolledback
any incomplete/active transaction.

i.e. Schematically
try
{
   // Old code that rollsback incomplete transaction
]
finally
{
    // Suspend any leftover transaction
    Transaction tx = tm.suspend();
    if (tx != null)
       log.error("Suspended tx=" + tx)
}

> Checking of Transaction Complete is missing rolled back transactions
> --------------------------------------------------------------------
>
>                 Key: JBAS-4487
>                 URL: http://jira.jboss.com/jira/browse/JBAS-4487
>             Project: JBoss Application Server
>          Issue Type: Sub-task
>      Security Level: Public(Everyone can see) 
>          Components: Transaction Manager
>    Affects Versions: JBossAS-4.2.0.GA
>            Reporter: Adrian Brock
>         Assigned To: Adrian Brock
>            Priority: Blocker
>             Fix For: JBossAS-4.2.1.CR1
>
>
> Checking of transaction complete is NOT trapping threads that have been rolled back
> but not removed from the transaction context of the thread.
> e.g. 
> 1) the transaction timed out and was rolled back
> 2) the user used the Transaction rather than TransactionManager api which did does not remove the thread association
> In
> org.jboss.ejb.plugins.AbstractTxInterceptorBMT
> and
> org.jboss.web.tomcat.service.jca.CachedConnectionValve
> There needs to be extra code (after the incomplete check) that says that if the tx status is not NO_TRANSACTION
> is does  TransactionManager.suspend(transaction) to remove the thread assocation.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira