[jboss-jira] [JBoss JIRA] Commented: (JBREM-755) Make ConnectorValidator parameters configurable

[Ron Sigal (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBREM-755?page=comments#action_12365666 ] 
            
Ron Sigal commented on JBREM-755:
---------------------------------

1. A new method, addConnectionListener(ConnectionListener listener, Map metadata), has been added to org.jboss.remoting.Client, and a corresponding constructor, ConnectionValidator(Client client, Map metadata), has been added to ConnectionValidator.

2. Four parameter keys are processed explicitly in ConnectionValidator.

 (a) ConnectionValidator.VALIDATOR_PING_PERIOD ("validatorPingPeriod"), which determines the frequency with pings are made.  The default is 2000 ms.
 
 (b) ConnectionValidator.VALIDATOR_PING_TIMEOUT ("validatorPingTimeout"), the value of which is passed as the "timeout" parameter to the client invoker which will do the pinging.  The default is 1000 ms.
 
 (c) "NumberOfCallRetries", which determintes the number of attempts that will be made to get a response to a ping.  The default is 1.  Note that this parameters applies only to the "socket" transport family.
 
 (c) "NumberOfRetries", which determines the number of attempts to get a connection to use to make a ping.  The default is 1.  Note that this parameters applies only to the "socket" transport family.
 
Note that a distinct timeout key "validatorPingTimeout" is used, rather than the standard key "timeout", because typically the timeout value used by ConnectionValidator will be smaller than the value used by the connection which is being monitored.
 
3. If the method Client.addConnectionListener(ConnectionListener listener, int pingPeriod) is called, then the value of pingPeriod is set according to the pingPeriod parameter, and the value of the other parameters is determined as follows:

   if (key is in the configuration map of the Client passed to the ConnectionValidator constructor)
      use associate value
   else use default value.

4. If the method Client.addConnectionListener(ConnectionListener listener, Map metadata) is called, then the value for all four of these parameters is determined as follows:

   if (key is in metadata map passed to Client.addConnectionListener())
      use associated value
   else if (key is in the configuration map of the Client passed to the ConnectionValidator constructor)
      use associated value
   else use default value.
   
5. Any additional (key, value) pairs in the metadata map are also passed to the pinging client invoker, with the exception of "timeout", which is ignored.

> Make ConnectorValidator parameters configurable
> -----------------------------------------------
>
>                 Key: JBREM-755
>                 URL: http://jira.jboss.com/jira/browse/JBREM-755
>             Project: JBoss Remoting
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.4.0.Beta1 (Pinto)
>            Reporter: Ron Sigal
>         Assigned To: Ron Sigal
>             Fix For: 2.4.0.Beta1 (Pinto)
>
>
> Currently org.jboss.remoting.ConnectionValidator hard codes the timeout value (1000 ms) and the number of attempts (1) to get a socket (socket transport family only).  It would be useful to be able to configure these parameters.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira