[jboss-jira] [JBoss JIRA] Resolved: (JBCOMMON-27) Incorrect behaviour in TCLFilter

[Scott M Stark (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBCOMMON-27?page=all ]

Scott M Stark resolved JBCOMMON-27.
-----------------------------------

    Resolution: Done

The change has been incorporate into the following branches:

https://svn.jboss.org/repos/common/common-old/branches/Branch_1_0/
https://svn.jboss.org/repos/common/common-old/branches/Branch_1_2/
https://svn.jboss.org/repos/common/common-old/branches/JBossCommon_1_0_0_GA_CP
https://svn.jboss.org/repos/common/common-logging-log4j/trunk


>  Incorrect behaviour in TCLFilter
> ---------------------------------
>
>                 Key: JBCOMMON-27
>                 URL: http://jira.jboss.com/jira/browse/JBCOMMON-27
>             Project: JBoss Common
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 1.0.0.GA
>            Reporter: Scott M Stark
>         Assigned To: Scott M Stark
>             Fix For: 1.0.5.GA, 2.2.1.GA
>
>
> Just one TCLFilter can be added to an appender, decide method return either ACCEPT or DENY.
> Should return NEUTRAL is some case.
> public int decide(LoggingEvent event)
> {
> int ok = Filter.DENY;
> if( acceptOnMatch == true )
> {
> ok = Filter.DENY;
> if( isMatchingTCL() ){
> ok = Filter.ACCEPT;
> }
> }
> else
> {
> ok = Filter.ACCEPT; // CHANGING THIS ROW TO ok = Filter.NEUTRAL; should do that you check the other filters to.
> if( isMatchingTCL() )
> ok = Filter.DENY;
> }
> return ok;
> }
> Log4j.xml:
>   <appender name="CONSOLE" class="org.apache.log4j.ConsoleAppender">
>     <layout class="org.apache.log4j.PatternLayout">
>       <param name="ConversionPattern" value="%d %-5p [%t] %c - %m%n"/>
>     </layout>
>     <filter class="org.jboss.logging.filter.TCLFilter">
>          <param name="AcceptOnMatch" value="false"/>
>          <param name="DeployURL" value="jboss-common-client.jarpoyan"/>
>     </filter>
>     <filter class="org.jboss.logging.filter.TCLFilter">
>          <param name="AcceptOnMatch" value="false"/>
>          <param name="DeployURL" value="dnsns.jarpoyan"/>
>     </filter>
>   </appender> 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira