[jboss-jira] [JBoss JIRA] Closed: (JBMESSAGING-287) RemotingTest.testConnectionListener() invalid

[Tim Fox (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBMESSAGING-287?page=all ]

Tim Fox closed JBMESSAGING-287.
-------------------------------

    Resolution: Done
      Assignee: Tim Fox

Ron's advice:


Try replacing

        Client client = new Client(serverLocator);

with

         HashMap metadata = new HashMap();
         metadata.put(InvokerLocator.FORCE_REMOTE, "true");
         metadata.put(Client.ENABLE_LEASE, "true");
         Client client = new Client(serverLocator, metadata);

Without the FORCE_REMOTE parameter, LocalClientInvoker gets used, in which case leasing is disabled, since it's pointless.  And ENABLE_LEASE tells Client to negotiate a lease with the server. Instead of metadata, it could go in the InvokerLocator, or, equivalently, it could be an attribute in the remoting-service.xml file with "isParam=true".

Now the test passes

> RemotingTest.testConnectionListener() invalid
> ---------------------------------------------
>
>                 Key: JBMESSAGING-287
>                 URL: http://jira.jboss.com/jira/browse/JBMESSAGING-287
>             Project: JBoss Messaging
>          Issue Type: Bug
>          Components: Tests and Performance
>            Reporter: Ovidiu Feodorov
>         Assigned To: Tim Fox
>            Priority: Minor
>             Fix For: 1.4.0.CR1
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> I commented out that test because I wanted a clean test run for the release and also because I think the test is invalid. 
> After the client connects I assume there is a separate thread that renews the lease on server, so even if the main thread sleeps for 5 secs, the client renews its lease and the ConnectionListener doesn't get called. Please verify my assumption and either fix the test or remove it. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira