[jboss-jira] [JBoss JIRA] Commented: (JBMESSAGING-916) CLONE -JDBCPersistenceManager and JDBCSupport do not close Statements

[jivkoto (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBMESSAGING-916?page=comments#action_12355281 ] 
            
jivkoto commented on JBMESSAGING-916:
-------------------------------------

There is no fix for jboss-messaging 1.2 Branch. I have tested the latest jboss-messaging-1.2.0.GA and the problem is not fixed.
Please take a look at :
org.jboss.messaging.core.plugin.JDBCSupport#createSchema and
org.jboss.messaging.core.plugin.JDBCPersistenceManager#loadFromStart

You do not close resources or reuse ResultSet-s without closing the previous objects.



> CLONE -JDBCPersistenceManager and JDBCSupport do not close Statements
> ---------------------------------------------------------------------
>
>                 Key: JBMESSAGING-916
>                 URL: http://jira.jboss.com/jira/browse/JBMESSAGING-916
>             Project: JBoss Messaging
>          Issue Type: Bug
>          Components: Messaging Core
>    Affects Versions: 1.0.1.GA, 1.2.0.Alpha2
>         Environment: JBoss 4.0.4 GA, Windows XP + SP2, MS SQL SERVER 2000
>            Reporter: jivkoto
>         Assigned To: Juha Lindfors
>            Priority: Minor
>             Fix For: 1.0.2.CR1
>
>   Original Estimate: 6 hours
>  Remaining Estimate: 6 hours
>
> After starting jboss-messaging configured to use MS SQLServer2000 there a lots of mumbles that there are lots of statements that are left open. 
> 10:38:32,265 WARN  [WrappedConnection] Closing a statement you left open, please do your own housekeeping
> java.lang.Throwable: STACKTRACE
> The places where the statements are left open are:
> org.jboss.jms.server.plugin.JDBCChannelMapper#createSchema
> org.jboss.messaging.core.plugin.JDBCPersistenceManager#createSchema
> Even if my report is for jboss-messaging 1.0.1.GA I checked the related places in jboss-messaging-1.2.0.Alpha2. And there is code such as conn.createStatement().executeUpdate(statement) too.
> The places I found it are:
> org.jboss.jms.server.plugin.JDBCJMSUserManager#insertUserRoleData
> org.jboss.messaging.core.plugin.JDBCSupport#createSchema
> Please close the statements. I hope that what I am reporting is useful for you. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira