[jboss-jira] [JBoss JIRA] Created: (JBAS-4193) Validation requirement should come from the model factory

[Scott M Stark (JIRA)]

Validation requirement should come from the model factory
---------------------------------------------------------

                 Key: JBAS-4193
                 URL: http://jira.jboss.com/jira/browse/JBAS-4193
             Project: JBoss Application Server
          Issue Type: Bug
      Security Level: Public (Everyone can see)
          Components: Deployment services, XML services
            Reporter: Scott M Stark
         Assigned To: Scott M Stark
             Fix For: JBossAS-5.0.0.Beta2


A regression relative to how we parse application.xml without validation jbossas4.2 and earlier is showing up in placeholder application.xml deployments like:

<!DOCTYPE application PUBLIC
   "-//Sun Microsystems, Inc.//DTD J2EE Application 1.3//EN"
   "http://java.sun.com/dtd/application_1_3.dtd">

<application>
   <display-name>Resource Loading Ear</display-name>
</application>


This fails because this dtd requires at least one module as well:

Caused by: org.jboss.xb.binding.JBossXBException: Failed to parse source: vfsfil
e:/C:/home/svn/JBossHead/jboss-head/testsuite/output/lib/unpacked/loadingresourc
e2.ear/META-INF/application.xml at 7,15
        at org.jboss.xb.binding.parser.sax.SaxJBossXBParser.parse(SaxJBossXBPars
er.java:173)
        at org.jboss.xb.binding.UnmarshallerImpl.unmarshal(UnmarshallerImpl.java
:180)
        at org.jboss.deployers.plugins.deployers.helpers.ObjectModelFactoryDeplo
yer.parse(ObjectModelFactoryDeployer.java:83)
        ... 70 more
Caused by: org.xml.sax.SAXException: The content of element type "application" i
s incomplete, it must match "(icon?,display-name,description?,module+,security-r
ole*)". @ vfsfile:/C:/home/svn/JBossHead/jboss-head/testsuite/output/lib/unpacke
d/loadingresource2.ear/META-INF/application.xml[7,15]
        at org.jboss.xb.binding.parser.sax.SaxJBossXBParser$MetaDataErrorHandler
.error(SaxJBossXBParser.java:406)
        at org.apache.xerces.util.ErrorHandlerWrapper.error(Unknown Source)
        at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source)
        at org.apache.xerces.impl.XMLErrorReporter.reportError(Unknown Source)
        at org.apache.xerces.impl.dtd.XMLDTDValidator.handleEndElement(Unknown S

To allow for similar behavior, we need to allow the ObjectModelFactory used by the deployer to indicate whether validation is needed. 


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira