[jboss-jira] [JBoss JIRA] Commented: (JBREM-645) Need to cleanup locatorURI parsing

[Ron Sigal (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBREM-645?page=comments#action_12360983 ] 
            
Ron Sigal commented on JBREM-645:
---------------------------------

It looks like adhering strictly to RFC 2396 "Uniform Resource Identifiers (URI): Generic Syntax" will entail semantic changes to InvokerLocator.  The example I see is the treatment of the path component.  By definition, the URI path component begins with "/", but InvokerLocator.getPath() doesn't return the initial "/".

Is it likely that changing getPath() to return the initial "/" would break existing software?  If so, a deprecated "classic" mode (settable by system property or static InvokerLocator switch) could be offered in the Remoting 2 InvokerLocator class and eliminated in Remoting 3.

> Need to cleanup locatorURI parsing
> ----------------------------------
>
>                 Key: JBREM-645
>                 URL: http://jira.jboss.com/jira/browse/JBREM-645
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: general
>    Affects Versions: 2.2.0.Alpha3 (Bluto)
>            Reporter: Scott M Stark
>         Assigned To: Ron Sigal
>             Fix For: 2.4.0.Beta1 (Pinto)
>
>
> Remoting is using its own parsing logic to extract the host and port when it should be using a URI object, and have a ctor supporting a URI type. This URI which parses fine via the URI class:
>       URI x = new URI("socket://succubus.starkinternational.com:4446?datatype=invocation");
>       int port = x.getPort();
> fails to parse when passed to the InvokerLocator
> 370232 ERROR [DeploymentWorker] Operation Distribute failed on target org.jboss.deployment.remoting.StreamingTarget at 11e9c82e
> java.lang.NumberFormatException: For input string: "4446?datatype=invocation"
> 	at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
> 	at java.lang.Integer.parseInt(Integer.java:456)
> 	at java.lang.Integer.parseInt(Integer.java:497)
> 	at org.jboss.remoting.InvokerLocator.<init>(InvokerLocator.java:191)
> 	at org.jboss.deployment.remoting.StreamingTarget.getClient(StreamingTarget.java:254)
> 	at org.jboss.deployment.remoting.StreamingTarget.deploy(StreamingTarget.java:140)
> 	at org.jboss.deployment.spi.DeploymentWorker.run(DeploymentWorker.java:74)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira