[jboss-jira] [JBoss JIRA] Updated: (JGRP-514) GroupRequest adjusts timeout improperly in doExecute

[Bryan Lanoue (JIRA)]

     [ http://jira.jboss.com/jira/browse/JGRP-514?page=all ]

Bryan Lanoue updated JGRP-514:
------------------------------

    Attachment: GroupRequest.java

GroupRequest class with extended trace level debugging and my solution to fix the timeout error. Generates a timeout after each response by subtracting current time from a fixed timeout time.

> GroupRequest adjusts timeout improperly in doExecute
> ----------------------------------------------------
>
>                 Key: JGRP-514
>                 URL: http://jira.jboss.com/jira/browse/JGRP-514
>             Project: JGroups
>          Issue Type: Bug
>    Affects Versions: 2.5
>         Environment: Linux/Windows
>            Reporter: Bryan Lanoue
>         Assigned To: Bela Ban
>            Priority: Minor
>             Fix For: 2.5
>
>         Attachments: GroupRequest.java, GroupRequestTest.java
>
>   Original Estimate: 20 minutes
>  Remaining Estimate: 20 minutes
>
> As GroupRequests are alerted to new responses, the total timeout to receive all responses decreases. This makes GroupRequests return from execute() without waiting for all responses within the true timeout.
> I think this can be fixed by (in the doExecute() method ) by adding
> start_time = System.currentTimeMillis();
> timeout_time = start_time + timeout;
> and replacing
> timeout = timeout - (System.currentTimeMillis() - start_time);
> with
> timeout = timeout_time - System.currentTimeMillis();
> 					

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira