[jboss-jira] [JBoss JIRA] Resolved: (JBRULES-871) Fix IDE tests after commiting JBRULES-500

[Edson Tirelli (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBRULES-871?page=all ]

Edson Tirelli resolved JBRULES-871.
-----------------------------------

    Resolution: Done

Kris,

As we briefly talked by e-mail, I moved Location class from IDE to the drools-compiler package. I also changed the DRL parser to populate an instance of this class during parsing, so the IDE gets more out of the parsing process. This means I was able to simplify the LocationDeterminator class by using this information from the parser.

There are though 2 situations where the parser can't provide accurate Location information:

1. Parser does not "see" white spaces, so any location information based on the presence or not of white spaces is not easily achievable from the parsing process

2. Code blocks: the parser sees code blocks ( eval, actions in accumulate, consequence block, etc) as black boxes and reads them on an all or nothing basis. 

To handle the 2 situations above, the LocationDeterminator class still needs to have some inteligence in it.

So, I commented out all old code in LocationDeterminator class, so you can review my changes. After you do, if you agree with them, please definitively remove the commented code.

Let me know if you have any question.

Thanks,
Edson

> Fix IDE tests after commiting JBRULES-500
> -----------------------------------------
>
>                 Key: JBRULES-871
>                 URL: http://jira.jboss.com/jira/browse/JBRULES-871
>             Project: JBoss Rules
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Eclipse IDE
>            Reporter: Edson Tirelli
>         Assigned To: Edson Tirelli
>             Fix For:  4.0.0.MR3
>
>
> Fix IDE tests after the implementation of JBRULES-500

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira