[jboss-jira] [JBoss JIRA] Created: (JBMESSAGING-977) JMSRemotingConnection.setFailed() has a redundant call to org.jboss.remoting.Client.disconnect()

[Ron Sigal (JIRA)]

JMSRemotingConnection.setFailed() has a redundant call to org.jboss.remoting.Client.disconnect()
------------------------------------------------------------------------------------------------

                 Key: JBMESSAGING-977
                 URL: http://jira.jboss.com/jira/browse/JBMESSAGING-977
             Project: JBoss Messaging
          Issue Type: Bug
            Reporter: Ron Sigal
         Assigned To: Tim Fox
            Priority: Minor


The call client.disconnect() occurs twice, and the first one should be removed.  The result of the first call is that the subsequent call to client.removeListener(callbackManager) fails:


2007-05-25 11:52:12,956 415134 DEBUG [org.jboss.jms.client.remoting.JMSRemotingConnection] (Thread-353:) JMSRemotingConnection[bisocket://10.5.2.224:4457/?NumberOfCallRetries=10&clientMaxPoolSize=100&clientSocketClass=org.jboss.jms.client.remoting.ClientSocketWrapper&dataType=jms&marshaller=org.jboss.jms.server.remoting.JMSWireFormat&numberOfRetries=5&serializationtype=jms&socket.check_connection=false&unmarshaller=org.jboss.jms.server.remoting.JMSWireFormat] failed to cleanly remove callback manager from the client
java.lang.Exception: Can not remove callback listener as remoting client is not connected to server.
at org.jboss.remoting.Client.removeListener(Client.java:1090)
at org.jboss.jms.client.remoting.JMSRemotingConnection.setFailed(JMSRemotingConnection.java:340)
at org.jboss.jms.client.FailoverCommandCenter.failureDetected(FailoverCommandCenter.java:100)
at org.jboss.jms.client.container.ConnectionFailureListener.handleConnectionException(ConnectionFailureListener.java:57)
at org.jboss.jms.client.remoting.ConsolidatedRemotingConnectionListener.handleConnectionException(ConsolidatedRemotingConnectionListener.java:83)
at org.jboss.remoting.ConnectionValidator$1.run(ConnectionValidator.java:346) 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira