[jboss-jira] [JBoss JIRA] Closed: (JBREM-820) Fix race in ServerInvokerCallbackHandler.handleCallback()

[Ron Sigal (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBREM-820?page=all ]

Ron Sigal closed JBREM-820.
---------------------------

    Resolution: Done

Fix applied to branch remoting_2_x.

No particular unit test.  If anything, should be covered by stress testing.

> Fix race in ServerInvokerCallbackHandler.handleCallback()
> ---------------------------------------------------------
>
>                 Key: JBREM-820
>                 URL: http://jira.jboss.com/jira/browse/JBREM-820
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: callbacks
>    Affects Versions: 2.4.0.Beta1 (Pinto), 2.2.2.GA_CP01, 2.2.2.SP2
>            Reporter: Ron Sigal
>         Assigned To: Ron Sigal
>             Fix For: 2.4.0.Beta1 (Pinto)
>
>
> org.jboss.remoting.callback.ServerInvokerCallbackHandler.handleCallback() calls  callBackClient.setSessionId(sessionId) without synchronization.  It's doing that so that the callback is sent to the client with a sessionId that matches the appropriate InvokerCallbackHandler on the client side.  However, I think that if two separate threads made the same call at the same time, callbackClient's sessionId could get messed up.
> The solution is to call callBackClient.setSessionId(sessionId) once in init() right after the Client has been created.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira