[jboss-jira] [JBoss JIRA] Commented: (GPD-143) Load the icon of a paletteContribution entry from the plugin directory where it is defined

Fri Nov 23 09:38:20 EST 2007

    [ http://jira.jboss.com/jira/browse/GPD-143?page=comments#action_12388922 ] 

Matthias Hanisch commented on GPD-143:
--------------------------------------

Just want to add that my local fix is very similar to Matthew's. I just computed the URL in the caller, but I would prefer Matthew's version.

> Load the icon of a paletteContribution entry from the plugin directory where it is defined
> ------------------------------------------------------------------------------------------
>
>                 Key: GPD-143
>                 URL: http://jira.jboss.com/jira/browse/GPD-143
>             Project: JBoss jBPM GPD
>          Issue Type: Feature Request
>          Components: jpdl
>            Reporter: Matthias Hanisch
>         Assigned To: Koen Aers
>             Fix For: jBPM jPDL Designer 3.2.0.alpha1
>
>         Attachments: PaletteRoot.java
>
>
> In PaletteRoot class, the icon of a palette entry is always loaded from org.jbpm.gd.jpdl plugin, even if the paletteContribution entry is defined in a dependent plugin.
> The information, where the palette entry element (entryElement in PaletteRoot.addControls) is defined, can be found in entryElement.getContributor().getName().
> So also the corresponding image can be loaded from the correct bundle.
> [ Sorry to only give a verbal description of the implementation. I would sign a corporate contributor's agreement, but I have problems with the procedure, e.g.
> - do we need a corporate jboss account for my boss to sign
> - if we sign with the "corporate" account, with which account I need to contribute then
> etc.
> So I would need some assistance here. Then you would get a real diff also.
> ]

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira