[jboss-jira] [JBoss JIRA] Updated: (JBPORTAL-1768) sanitize captcha parameter setup

[Emanuel Muckenhuber (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBPORTAL-1768?page=all ]

Emanuel Muckenhuber updated JBPORTAL-1768:
------------------------------------------

    Priority: Minor  (was: Major)

The first spot declaration of 'showCaptcha' makes indeed no sense because it's never used - most likely a relict when portletPreferences could not be resolved. The only idea behind putting the condition into the captcha.xml was to keep the registration page as simple as possible, because it should be editable by users. Anyway i will take a look at that again. Thanks

> sanitize captcha parameter setup
> --------------------------------
>
>                 Key: JBPORTAL-1768
>                 URL: http://jira.jboss.com/jira/browse/JBPORTAL-1768
>             Project: JBoss Portal
>          Issue Type: Patch
>      Security Level: Public(Everyone can see) 
>    Affects Versions: 2.6.2 Final
>            Reporter: Andrew Oliver
>         Assigned To: Emanuel Muckenhuber
>            Priority: Minor
>             Fix For: 2.6.3 Final
>
>         Attachments: captcha.patch, captcha2.patch
>
>
> The captcha is configured in one spot as a variable and in another spot as a preference.  This uses the preference to configure the variable and then the variable throughout.  Moreover, it seems cleaner to not have captcha.xhtml itself worrying about whether captcha is enabled for registration, rather have registration do that.  Somewhat pedantic...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira