[jboss-jira] [JBoss JIRA] Resolved: (JBPORTAL-1672) IdentityServiceControllerImpl.java : error message enhancement, (to help find error in config files)

[Thomas Heute (JIRA)]

     [ http://jira.jboss.com/jira/browse/JBPORTAL-1672?page=all ]

Thomas Heute resolved JBPORTAL-1672.
------------------------------------

    Resolution: Done
      Assignee: Thomas Heute

Done in the sources (i didn't rebuild the jar yet though)

> IdentityServiceControllerImpl.java : error message enhancement, (to help find error in config files)
> ----------------------------------------------------------------------------------------------------
>
>                 Key: JBPORTAL-1672
>                 URL: http://jira.jboss.com/jira/browse/JBPORTAL-1672
>             Project: JBoss Portal
>          Issue Type: Feature Request
>      Security Level: Public(Everyone can see) 
>          Components: Portal Identity
>    Affects Versions: 2.6.1 Final
>            Reporter: Antoine Herzog
>         Assigned To: Thomas Heute
>             Fix For: 2.6.2 Final
>
>
> In file : IdentityServiceControllerImpl.java
> One error message is not very helpfull.
> Line : 170
>             //check if defaults contains all information
>             if (module.getType() == null ||
>                module.getImplementation() == null ||
>                //module.getJNDIName() == null ||
>                module.getServiceName() == null ||
>                module.getConfig() == null)
>             {
>                throw new IdentityException("Default module configuration must be complete");
>             }
> This could help better, showing what is missing (and in what Type, which implementation...) :
> 				if (module.getType() == null
> 						|| module.getImplementation() == null
> 						||
> 						// module.getJNDIName() == null ||
> 						module.getServiceName() == null
> 						|| module.getConfig() == null) {
> 					throw new IdentityException(
> 							"Default module configuration must be complete."
> 									+ "module=[" + module + "]" + ", "
> 									+ "module.getType()=[" + module.getType()
> 									+ "]" + ", "
> 									+ "module.getImplementation()=["
> 									+ module.getImplementation() + "]" + ", "
> 									+ "module.getServiceName()=["
> 									+ module.getServiceName() + "]" + ", "
> 									+ "module.getConfig()=["
> 									+ module.getConfig() + "]");
> 				}
> Also :
> may be the same kind of things on some other errors.
> a log (trace level) to tell which files are used (to make sure if they are changed), and which type and implementation are worked : it will help understanding when an exception happens.
> I guess this will be helpfull to people changing the configuration.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira