[jboss-jira] [JBoss JIRA] Commented: (JBPM-756) log.debug calls are unprotected

[Ronald van Kuijk (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBPM-756?page=comments#action_12375039 ] 
            
Ronald van Kuijk commented on JBPM-756:
---------------------------------------

ok, I'll do it.... no problem

> log.debug calls are unprotected
> -------------------------------
>
>                 Key: JBPM-756
>                 URL: http://jira.jboss.com/jira/browse/JBPM-756
>             Project: JBoss jBPM
>          Issue Type: Bug
>          Components: Core Engine
>    Affects Versions:  jBPM 3.1.2
>         Environment: Window XP, Java 5
>            Reporter: Dave Caruana
>         Assigned To: Tom Baeyens
>             Fix For: jBPM 3.3
>
>
> Within org.jbpm.context.exe.VariableContainer there are calls to log.debug.  In particular:
> line 156:      log.debug("create variable '"+name+"' in '"+this+"' with value '"+value+"'");
> line 160:      log.debug("update variable '"+name+"' in '"+this+"' to value '"+value+"'");
> However, they are unprotected i.e. the method is called even if debug logging is not switched on.  This is not too much of a problem if the variable value is of a primitive type, but sometimes, values can be complex (including their toString()).
> "if (log.isDebugEnabled())" statements are missing.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira