[jboss-jira] [JBoss JIRA] Resolved: (JGRP-590) FC: messages > max_credits will block forever

[Bela Ban (JIRA)]

     [ http://jira.jboss.com/jira/browse/JGRP-590?page=all ]

Bela Ban resolved JGRP-590.
---------------------------

    Fix Version/s:     (was: 2.5.1)
                       (was: 2.4.1 SP5)
       Resolution: Done

Since this doesn't block forever, it will get fixed only in 2.6

> FC: messages > max_credits will block forever
> ---------------------------------------------
>
>                 Key: JGRP-590
>                 URL: http://jira.jboss.com/jira/browse/JGRP-590
>             Project: JGroups
>          Issue Type: Task
>            Reporter: Bela Ban
>         Assigned To: Bela Ban
>            Priority: Minor
>             Fix For: 2.6
>
>
> FC.down checks for the message size. If that size is greater than the credits left, we block until we get more credits from the receiver(s). However, if the message size is greater than *max_credits*, we will *never* have more than max_credits available to send the message, so we'd block forever !
> To prevent running into this, we need to check (at startup time) in FC that
> - a fragmentation protocol is available (somewhere above the FC protocol) 
> - that the max fragmentation size of the fragmentation protocol is smaller than max_credits
> We should also log a (fatal) error message if we receive a message whose size is greater than max_credits (this should *not* happen anymore though after the proposed change above)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira